Add error handling and messages to prevent running develop#148
Add error handling and messages to prevent running develop#148breakerbar wants to merge 1 commit intoreactioncommerce:trunkfrom breakerbar:issue23
Conversation
… directory without a project already defined Signed-off-by: Matthew Palombi <matt@breakerbar.com>
brent-hoover
left a comment
brent-hoover
left a comment
There was a problem hiding this comment.
@breakerbar When I test this running it in a directory with a package.json I get the error:
reaction-cli: Error while parsing package.json
reaction-cli: No project type found
I also get it in a valid project
|
@breakerbar You will also want to fix up your commit message |
|
Taking a look - I think I know what it could be. I'm assuming that when you run |
|
@zenweasel What is the exact command you're running and what is |
|
I get the same error regardless of where I run it from. Seems like it's having a problem parsing the package.json for some reason. I'm running reaction develop in every case |
|
Thanks - I can duplicate it on my side, working on it now. |
|
@breakerbar Just pinging you that Hacktober is almost over if you want to get this in |
|
thanks - I plan to get to it, but it might be later this week. |
2 participants
Add error handling and messages to prevent running develop while in a directory without a project already defined
solves #23